Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add seccompProfile to controller #955

Merged

Conversation

KauzClay
Copy link
Contributor

@KauzClay KauzClay commented Sep 12, 2023

Changes

  • 🧹
  • I believe this PR adds the seccompProfile part to the net-contour controller in the serving repo, but I think we should add it to the controller directly instead

/kind

Fixes #

Release Note

Controllers and webhooks now have seccompProfile.type set to RuntimeDefault

Docs

N/A

* I believe this [PR](knative/serving#13327) adds it to the controller in the serving repo,
  but why not do it in the net-contour repo too?
@knative-prow
Copy link

knative-prow bot commented Sep 12, 2023

@KauzClay: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

  • 🧹
  • I believe this PR adds the seccompProfile part to the net-contour controller in the serving repo, but I think we should add it to the controller directly instead

/kind

Fixes #

Release Note

N/A

Docs

N/A

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 12, 2023
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2023
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #955 (20e12fd) into main (d7706f5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #955   +/-   ##
=======================================
  Coverage   93.89%   93.89%           
=======================================
  Files           7        7           
  Lines         802      802           
=======================================
  Hits          753      753           
  Misses         28       28           
  Partials       21       21           

@dprotaso
Copy link
Contributor

/lgtm
/approve
/cherry-pick release-1.11

@knative-prow-robot
Copy link
Contributor

@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you.

In response to this:

/lgtm
/approve
/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2023
@knative-prow
Copy link

knative-prow bot commented Sep 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, KauzClay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit a02a918 into knative-extensions:main Sep 13, 2023
21 checks passed
@knative-prow-robot
Copy link
Contributor

@dprotaso: new pull request created: #956

In response to this:

/lgtm
/approve
/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants